apol marked 6 inline comments as done. apol added inline comments. INLINE COMMENTS
> broulik wrote in startplasma.cpp:82 > Should we also check for executable permission? We don't now and it's not required. I'd aim at not changes in behaviour. > broulik wrote in startplasma.cpp:241 > Would it make a difference using libxcb for this instead of spawning an > external process synchronously here? I wonder so as well. Possibly. It would also make the process link against libxcb. Something to try I'd say. Maybe once it's in. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21725 To: apol, #plasma, fvogt Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
