sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY QFileDialog was already run with confirmOverwrite, but we didn't actually set the Overwrite flag on the copy call, so we got an error back when the file already existed. Since the user already needed to confirm the overwrite in the QFD we can always pass Overwrite. BUG: 405597 CHANGELOG: Saving backtraces now overwrites files when necessary FIXED-IN: 5.16.1 TEST PLAN - save backtrace - save again - dialog asks to confirm overwrite - gets overwritten succesfully - save again - refuse to overwrite - dialog stays open until cancel or new path is chosen - no overwrite REPOSITORY R871 DrKonqi BRANCH 405597-2 REVISION DETAIL https://phabricator.kde.org/D21645 AFFECTED FILES src/drkonqi.cpp To: sitter, #plasma Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
