broulik added a comment.

  Does that by chance also fix the dictionary runner which does network queries 
that take a while?

INLINE COMMENTS

> sourcesmodel.h:93
> +     * Clears the model content and resets the runner context, i.e. no new 
> items appear.
> +     * Plasma 6 TODO: Replace this with bool clear(bool resetContext=true);
> +     */

more like a flags thing :), also `TODO Plasma 6` this way round pls

> sourcesmodel.h:100
> +     */
> +    void clearContent(bool resetContext);
>  

Yeah please avoid a boolean trap, `clearContent(false)` isn't very obvious

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D21605

To: fvogt, #plasma
Cc: broulik, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to