fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  `browser.runtime.sendMessage` does not seem to have a callback parameter.
  
  See 
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/sendMessage:
  
  > if two arguments are given:
  >  the arguments are interpreted as (message, options), and the message is 
sent internally, if the second argument is any of the following:
  >  a valid options object (meaning, it is an object which contains only the 
properties of options that the browser supports)
  > null
  > undefined
  >  otherwise, the arguments are interpreted as (extensionId, message). The 
message will be sent to the extension identified by extensionId.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21112

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to