mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed.
I don't like adding a new property to separator for doing duck typing... even is really ugly and errorprone as well, but i would prefer Layout.topMargin: item.toString().indexOf("Separator")===0 ? Kirigami.Units.smallSpacing : 0 with a comment: // FIXME: use item instanceof Kirigami.Separator when we can depend from Qt 5.11 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D20585 To: filipf, mart, #kirigami, ngraham Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein