broulik created this revision. broulik added reviewers: Plasma, hein, mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY This removes the setting from the individual plasmoid and has it follow global settings in the new KCM. Since the new `JobsModel` also emits application jobs via the Unity launcher API, the codepath for dealing with jobs is dropped and instead it only listens to Unity signals now. TEST PLAN Depends on D20265 <https://phabricator.kde.org/D20265> There's still something funky going on with shared pointer ownership, when I disable notification applet jobs the model is deleted for some reason... also, do not disturb mode doesnt auto expire as I dont check the time periodically (might slap in the time dataengine like I do in notifications). It cannot tell between genuine badges and job badges, so when you disable job tracking you stil get a badge of "1" thing going on. Also, since the setting is global now, the smart launcher stuff is always loaded but it's just one more qobject per task and the QML bits for progress and badges are behind loaders already, only loading when there is a progress or badge to be displayed. Other than that, works well, even with Latte Dock. - Copied files in dolphin, progress showed up - Set a badge on an app, showed up - Changed settings, they updated the thing live REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21061 AFFECTED FILES CMakeLists.txt applets/taskmanager/CMakeLists.txt applets/taskmanager/package/contents/config/main.xml applets/taskmanager/package/contents/ui/ConfigAppearance.qml applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.h applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.h To: broulik, #plasma, hein, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
