mart added a comment.

  from the screenshots, i like it a lot,the code seems clean enough.
  
  However, to continue with that i think some attempt should be done to make 
qwidget based apps follow this as well. (I think we should go on a campaign to 
remove unnecessary frames here too)
  
  with qwidget is perhaps slightly harder to do, but should be totally possible
  F6811509: Screenshot_20190506_110307.png 
<https://phabricator.kde.org/F6811509>
  
  another issue is that (as kirigami apps) this may look a bit bad with the 
window borders which unfortunately are still default on

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to