davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land.
One comment, please include when committing INLINE COMMENTS > ConfigFilter.qml:33-34 > > width: childrenRect.width > height: childrenRect.height > These lines are quite wrong to begin with, but resizing childenRect inside a columnLayout now becomes doubly wrong. It's a clear binding loop as children are resized to the layout. If you don't have a tonne of warnings being printed, it probably means these properties get override by the instantiator of this Item. Please kill them. REPOSITORY R119 Plasma Desktop BRANCH containments-desktop-port-desktop-settings-pages-to-qqc2-plus-kirigami-formlayout-and-modernize-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D20878 To: GB_2, #plasma, #vdg, davidedmundson Cc: davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
