ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Why doesn't mouse wheel scrolling with with `ScrollView`? That seems odd and 
unexpected. I would recommend we use that component and figure out why it 
doesn't work. Also it seems semantically incorrect to be putting a 
`ScrollablePage`//inside// a page. That thing is supposed to be the whole page, 
not one component of it.
  
  BTW, since while using `ScrollView` you'll probably run into this, to make a 
QQC2 ScrollView display its frame, you do this:
  
    QQC2.ScrollView {
        Component.onCompleted: background.visible = true;
        [blabla]
    }
  
  Also LOL we really need to fix that broken icon: 
https://bugs.kde.org/show_bug.cgi?id=399568

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20797

To: filipf, dfaure, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to