broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY When the player is reparented we get a DOM removal event which prompts us to forget the player and transfer controls to another player. However, the player might just be reparented elsewhere. There's a race between we transfer controls to previous player on a different tab and us activating the player again when it reappeared. TEST PLAN Switching full screen back and forth in YouTube works fine now (now, really! :D) Verified that closing a twitter video overlay still considers the player gone (which was the main point of this mutation observer, detecting when a video player is removed dynamically) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20582 AFFECTED FILES extension/content-script.js To: broulik, #plasma, fvogt Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart