broulik accepted this revision.
broulik added inline comments.
INLINE COMMENTS
> CMakeLists.txt:77
>
> +
> +
Stray whitespace
> ddcutilbrightness.cpp:38
> // Inquire about detected monitors.
> - DDCA_Display_Info_List * dlist = ddca_get_display_info_list();
> - qCDebug(POWERDEVIL) << "ddca_get_display_info_list() returned "<< dlist;
> + DDCA_Display_Info_List * dlist = NULL;
> + ddca_get_display_info_list2(true, &dlist);
`nullptr`
> ddcutilbrightness.cpp:71
> +
> +// if (ddca_feature_list_contains(&vcpList,
> m_usedVcp.value(iVcp))) {
> +// tmpVcpList.append(m_usedVcp.value(iVcp));
Remove commented code
> ddcutilbrightness.cpp:82
> + //we only store displays that actually support the features we want.
> + if( tmpVcpList.contains(0x10) ) {
> + qCDebug(POWERDEVIL) << "Display supports Brightness, adding
> handle to list";
Coding style: `if (...) {`
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D8626
To: dvogel, broulik, davidedmundson
Cc: ngraham, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
