leinir planned changes to this revision. leinir marked an inline comment as done. leinir added inline comments.
INLINE COMMENTS > apol wrote in KNSResource.cpp:213 > Can't we do this in the adoption command? This way we won't have another > special case. Hmm... I guess we could... It requires making a choice in the knsrc file on which tool to use for using the app, which i guess might be e.g. AppImageLauncher... but i guess that isn't really that much of a problem anyway. Sure, i'll just do that instead. And yes, less special cases are certainly nice :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D20378 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
