broulik added inline comments.

INLINE COMMENTS

> ConfigIcons.qml:266
> +
> +            model: ListModel {
> +                ListElement { text: "Narrow" }

You can just use a JavaScript `Array`:

  model: [
      i18n("Narrow"),
      i18n("Medium"),
      i18n("Wide")
  ]

This way you can also use `i18n` for translation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20370

To: ngraham, hein, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to