davidedmundson added inline comments.

INLINE COMMENTS

> SpinBox.qml:74
>              onWheel: {
> -                if (wheel.pixelDelta.y < 0 || wheel.angleDelta.y < 0) {
> -                    controlRoot.decrease();
> -                } else {
> +                var delta = wheel.angleDelta.y || wheel.angleDelta.x
> +                wheelDelta += delta;

Does this match the widget? It seems sensible if you you had two physical 
wheels, if it was exposed as a scroll-ball, this behaviour seems a bit weird.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D20155

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to