apol added a comment.

  Overall this makes sense to me, this assumes though that there will never be 
a file ending with `:digit`, is that something we can live with?

INLINE COMMENTS

> urlinfo.h:68
> +             */
> +            line = match.captured(1).toUInt();
> +            column = match.captured(2).toUInt();

capturedRef, no need to instantiate the QString to destroy again.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Reply via email to