leinir added inline comments.

INLINE COMMENTS

> ngraham wrote in KNSBackend.cpp:68
> Needs to be 57 now (we'll get all of this landed soon, not to worry!)
> 
> Also, should the second one be `KNEWSTUFFCORE_VERSION_MINOR`? Seems weird 
> that both conditions are checking the major version.

It does indeed! Good catch before landing time, too :)

wwwwoooow... yes, yes it should, not sure how i missed that :D

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19340

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to