ndavis added subscribers: trickyricky26, ndavis. ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed.
I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well. Resize: I don't like how busy that icon looks, but I"m not sure if it's worth it to make a new icon just for resizing windows. Maximize: The maximize icon is more like a "Maximized" icon because we normally use the up arrow for "Maximize". @trickyricky26 is already working on the shade icon and I know you requested keep-above and keep-below icons, so I'll ignore those for now. INLINE COMMENTS > ContextMenu.qml:569 > + text: i18n("&Fullscreen") > + icon: "window-keep-above" > + Why was this changed from `view-fullscreen`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis Cc: ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart