sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed.
That seems to break the category icons because `KDE::icon(menuItem->kcm().icon()` is only working on Kcm entries, while KcmCategory entries overload `::icon` with divergent behavior. I think what we need is to change `KcmTreeItem::icon()` (and its derived class KcmCategoryItem) to `QString KcmTreeItem::iconName()` and use that on the KDE::icon call. And `InfoKcmModel::data` needs changing to `QIcon::fromTheme(item->iconName())` I guess. F6670271: Screenshot_20190307_170538.png <https://phabricator.kde.org/F6670271> REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
