broulik added a comment.
> There don't seem to be any other instances of it being used? plasma-workspace/shell/osd.cpp It also seems kscreen has a copy of thhis OSD which also needs fixing, and please also make sure the lockscreen doesn't break as it also embeds an OSD item. > I don't understand, could you elaborate please? The aforementioned code checks if an `animateOpacity` property is present, if so, it changes the window `opacity` which will then be animated. If that property is gone, the code just sets the window `visible` which will be animated by KWin. As such, the animation in the osd.qml is entirely unused now. REPOSITORY R120 Plasma Workspace BRANCH osd-effect-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D19566 To: rooty, #plasma, #vdg, davidedmundson, ngraham Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
