sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY the module help button specifically launches the help for DocPath set in the desktop file of the KCM, previously the code however only checked if the KCM pragmatically disabled the help button. while supposedly its good form for a module to explicitly disable the help button when it has no help but since that depends on humans to remember doing that it's a bit unreliable. so, the module help button now only gets enabled when there actually is module help available AND the button wasn't explicitly disabled. this prevents the help button from getting enabled but then launching the generic khelpcenter since no actual DocPath was set in the kcm desktop metadata TEST PLAN - about (has no doc and disables button) -> disabled button - memory (has doc) -> enabled button - energy (has no doc but doesn't explicitly disable button) -> disabled button REPOSITORY R102 KInfoCenter BRANCH better-help REVISION DETAIL https://phabricator.kde.org/D19188 AFFECTED FILES infocenter.cpp To: sitter Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
