filipf added a comment.

  If I just change Text to Labels and remove hardcoded sizes, we won't be able 
to fit all the text in. We would then have to increase the root height to 
accommodate the text. This would only give us a good solution for the default 
font settings (10pt Noto Sans) with no scaling used.
  
  Here's my idea for how to make it work in all conditions (mockup):
  
  F6619405: sddm-kcm-p1.png <https://phabricator.kde.org/F6619405>
  
  1. change the root element from a Rectangle to ScrollView -> scaling and big 
fonts will dramatically increase the labels and we will simply not be able to 
fit them in
  2. push this ScrollView's height all the way down so that "Background" 
(controlled by QWidgets btw) gets pushed as low as it can get -> IDK how to do 
this without setting height to something huge
  3. use ColumnLayout instead of GridView -> so that scaling and big fonts 
don't break the two column layout

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to