Zren created this revision. Zren added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision.
REVISION SUMMARY In 12h system locales (eg: en_US), checked=1 is cast as Qt::PartiallyChecked=1 which defaults to the system locale (12h). Since it's no longer a tri-state button, the user can't select Qt::Checked=2 which forces the 24h state. BUG: 404292 FIXED-IN: 5.15.1 TEST PLAN - Run `LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock` and confirm it's a 2 state button that doesn't enable 24h clock. - Patch `/usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/configAppearance.qml` - Run `LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock` and confirm it's a 3 state button that does force the 24h clock. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19021 AFFECTED FILES applets/digital-clock/package/contents/ui/configAppearance.qml To: Zren, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
