ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  > No other KDE app does this
  
  That's not true. Kate and Gwenview do this too, and for good reason: without 
this warning, there's no way to know how to get the menu bar back again if you 
remove it by accident and/or don't know about the [ctrl] + [m] shortcut.
  
  Konsole doesn't show a warning because it's a power user app; presumably the 
user knows what he/she is doing. Dolphin doesn't have this warning because it 
automatically creates a menu-like toolbar button when the menubar is hidden, 
which is an acceptable alternative. But for apps that don't do this or 
something else (e.g. putting the menubar in the titlebar instead) we need to 
show an ugly warning like this.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D18575

To: tcanabrava, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to