hein added a comment.

  I think it needs to be made a bit more robust still. For one it's not called 
`requestClose()` without reason: Not all windows are closable / will be closed 
upon this request. It might also race with a different window closing going on 
in parallel. `taskClosedWithMouseMiddleButton` needs to be invalidated on exit, 
and the middle-click close and `onItemRemoved` probably need to compare 
persistent model indexes or window ids (easier) to check it's the same.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to