apol added inline comments. INLINE COMMENTS
> broulik wrote in ComboBox.qml:58 > Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a > `ComboBox` is recommended as: > "This ensures that the interaction works as expected, and the popup will > automatically close when appropriate. " > The `currentIndex` change makes sense, though otherwise it didn't work. I may have overlooked something though. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18299 To: apol, #frameworks, davidedmundson Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
