davidedmundson added inline comments.

INLINE COMMENTS

> harmathy wrote in fonts.cpp:505
> This doesn't work on current kde-neon/dev/unstable
> 
> The Qt documentation http://doc.qt.io/qt-5/qqmlengine.html#addImageProvider 
> says:
> 
> > All required image providers should be added to the engine before any QML 
> > sources files are loaded.
> 
> At this point however qml files are already loaded.

What prevents us moving this to the constructor?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17493

To: harmathy
Cc: davidedmundson, broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to