ngraham added inline comments.

INLINE COMMENTS

> DeviceItem.qml:308
>                  onClicked: actionTriggered()
> +                y: mounted ? deviceLabel.height + (freeSpaceBar.height - 
> height) / 2 - 2 : (deviceLabel.height + actionMessage.height - height) / 2
>              }

`- 2` looks like a magic number. Might that be better expressed as 
`units.smallSpacing / 2` instead?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17420

To: thsurrel, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to