amantia created this revision. amantia added reviewers: Plasma, Plasma Accessibility, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision.
REVISION SUMMARY The ev->xkbType looks to be a value that is defined in xkb.xml (usually in /usr/share/xcb), and that indicates which bit refers to a certain event. The XCB_XKB_EVENT_TYPE_* enum is a bitmask value though, they cannot be compared directly. E.g BellNotify even mean bit 8 is set, that means the value is 2^8 = 256. This fixes bell, visual bell and accessibility event handling. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17415 AFFECTED FILES kaccess/kaccess.cpp To: amantia, #plasma, #plasma_accessibility, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart