broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY In Chrome we get state change to "interrupted" and the error in unison whereas Firefox first signals a state change and then updates the error later. Previously, we would finish the job as soon as it was interrupted leading to a "unknown error" any time a download aborted (even if explicitly canceled by the user). This patch remembers both state and error and then delays finishing the download slightly. BUG: 385530 TEST PLAN - Started a download in Firefox, canceled it, no longer got an "unknown error" notification - Still works in Chrome REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D17233 AFFECTED FILES host/downloadjob.cpp host/downloadjob.h To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
