ngraham created this revision. ngraham added reviewers: Plasma, cfeck. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY BUG: 350663 FIXED-IN: 5.12.8 When choosing a default browser app using the app list combobox, the choice was noly being saved after the combobox was used, because its signal was connected to an inline function that saved the choice, while the radio button that enabled the combobox was not. As a result, if you clicked on that radio button and didn't need to use the combobox because it was already showing your preferred browser, that action was not actually getting saved. This patch fixes the situation ym moving the inline function into a real explicit slot function and connecting the radio button to it as well TEST PLAN - Go to the component chooser KCM's default browser module - Reset to defaults, then leave the KCM and open it again - Click the in the following application radio button - Do NOT touch the combobox - Click Apply - Leave the KCM and come back With this patch, the radio button's state is preserved and the correct browser is selected in the combobox. REPOSITORY R119 Plasma Desktop BRANCH fix-default-browser-app-combobox (branched from Plasma/5.12) REVISION DETAIL https://phabricator.kde.org/D17181 AFFECTED FILES kcms/componentchooser/componentchooserbrowser.cpp kcms/componentchooser/componentchooserbrowser.h To: ngraham, #plasma, cfeck Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
