romangg added a comment.

  I like all the changes, but they should go into separate patches:
  
  > (1) Keeps the search field visible by default but leaves it unfocused until 
triggered by the keyboard
  
  Patch 1
  
  > (2) Enables the tab key to select/focus the search field just like any 
other key
  
  Patch 2
  
  > (3) Enables the escape key to collapse Kickoff when pressed from within an 
empty focused search field that was activated by either a mouse click
  >  or the tab key (a bug in the previous version of Kickoff evident due to an 
unfocused search area)
  >  (4) Enables the escape key to return the user to the tabbed view in 
Kickoff when pressed from within a non-empty search field
  
  Patch 3
  
  > (5) Changes the label 'Search...' to 'Type to search...' so that the user 
is made aware that they can, in fact, type to search
  >  (6) Maintains the ability to hover over the user's name to show more 
information about the system
  >  (7) Lowers the font size of the username to make it fit in better with the 
search field and user picture/avatar
  
  Patch 4
  
  You could use this diff here for patch 1 and split the other changes into 
dependent diffs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to