anthonyfieroni added inline comments. INLINE COMMENTS
> appmenumodel.cpp:245-248 > + if (info.isMinimized()) { > + setMenuIsHidden(true); > + } else { > + setMenuIsHidden(false); setMenuHidden(info.isMinimized()); > appmenumodel.h:42 > Q_PROPERTY(bool menuAvailable READ menuAvailable WRITE setMenuAvailable > NOTIFY menuAvailableChanged) > + Q_PROPERTY(bool menuIsHidden READ menuIsHidden NOTIFY > menuIsHiddenChanged) > Naming should be menuHidden, setMenuHidden if we follow rules. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16715 To: mvourlakos, #plasma, broulik Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart