jgrulich added a comment.
I still don't like the way how to get QPalette in the advanced dialog, can you please just simply construct it the same way you do it in the standard dialog? Other than that it looks good and I think it's ready to go. Those mentioned coding style can be fixed later, I can go through that after it's merged. INLINE COMMENTS > wireguardadvancedwidget.cpp:48 > + > +WireGuardAdvancedWidget::Private::Private() : fwMarkValid(true), > + presharedKeyValid(true), Coding style, but can be fixed afterwards. > wireguardwidget.cpp:52 > + > +WireGuardSettingWidget::Private::Private(void) : addressValid(false), > + privateKeyValid(false), Coding style, can be fixed afterwards. > wireguardwidget.cpp:75 > + KColorScheme::adjustBackground(d->warningPalette > + , KColorScheme::NegativeBackground > + , QPalette::Base Coding style REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
