hein updated this revision to Diff 44671. hein added a comment.
- Sync ids before syncing names. - Remove the dummy id swap, it's no longer needed given the above. - Add a class description comment that illuminates the sync/detach behavior. - Reindent headers. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=44498&id=44671 BRANCH arcpatch-D14542_2 REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTED FILES CMakeLists.txt abstract_client.cpp abstract_client.h autotests/CMakeLists.txt autotests/integration/virtual_desktop_test.cpp autotests/test_window_paint_data.cpp dbusinterface.cpp dbusinterface.h deleted.cpp deleted.h effects.cpp effects/desktopgrid/desktopgrid.cpp effects/desktopgrid/desktopgrid.h kcmkwin/kwindesktop/CMakeLists.txt kcmkwin/kwindesktop/Messages.sh kcmkwin/kwindesktop/desktop.desktop kcmkwin/kwindesktop/desktopnameswidget.cpp kcmkwin/kwindesktop/desktopnameswidget.h kcmkwin/kwindesktop/desktopsmodel.cpp kcmkwin/kwindesktop/desktopsmodel.h kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop kcmkwin/kwindesktop/main.cpp kcmkwin/kwindesktop/main.h kcmkwin/kwindesktop/main.ui kcmkwin/kwindesktop/package/contents/ui/main.qml kcmkwin/kwindesktop/package/metadata.desktop kcmkwin/kwindesktop/virtualdesktops.cpp kcmkwin/kwindesktop/virtualdesktops.h libkwineffects/kwineffects.cpp libkwineffects/kwineffects.h org.kde.KWin.VirtualDesktopManager.xml toplevel.h unmanaged.cpp unmanaged.h useractions.cpp useractions.h virtualdesktops.cpp virtualdesktops.h virtualdesktopsdbustypes.cpp virtualdesktopsdbustypes.h wayland_server.cpp wayland_server.h workspace.cpp workspace.h To: hein, mart, davidedmundson, ltoscano, zzag Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart