hein added inline comments. INLINE COMMENTS
> davidedmundson wrote in main.qml:425 > I would have expected just folderViewLayer.forceActiveFocus() to work? > > the FolderViewLayer item should be the only item within the Loader (which is > a focus scope) and you added focus: true to FolderViewLayer Maybe, but if you look at the diff, what this is replacing is indiscriminately doing `root.forceActiveFocus()`, which isn't good enough. root is the FolderViewDropArea, which is not a FocusScope and can't be. ... however, I added the focus-forwarding (root.onFocusChanged) in a later change - which means I can now actually clean this up again. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D16106 To: hein, broulik, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
