davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision.
REVISION SUMMARY Removing this is part of preparations for ksmserver to become just an X session manager. See T9779 <https://phabricator.kde.org/T9779>. Instead of ksmserver opening the greeter with a tonne of args and then having a socket to watch for changes, the new mechanism is that we fire and forget the prompt. Then the logout prompt calls back into ksmserver with the request. Simplifies code greatly allows for moving. KSMserver's shutdown DBus method remain on ksmserver for compatibility, but ultimately spawning the prompt will move to libkworkspace and called from the session directly. QML API in the logout greeter remains mostly untouched. Behavioural changes are minor: There was a QML property "choose" exposed to the greeter if the default shutdown option is set to None. Though we don't allow this in the KCM and our default prompt doesn't use it. We no longer block a user from saving a session whilst a logout prompt is active. TEST PLAN Logged out Shutdown Also ran with old ksmserver, still got a prompt REPOSITORY R120 Plasma Workspace BRANCH ksmserver_split REVISION DETAIL https://phabricator.kde.org/D16066 AFFECTED FILES ksmserver/CMakeLists.txt ksmserver/org.kde.LogoutPrompt.xml ksmserver/server.cpp ksmserver/server.h ksmserver/shutdown.cpp logout-greeter/CMakeLists.txt logout-greeter/greeter.cpp logout-greeter/greeter.h logout-greeter/main.cpp logout-greeter/shutdowndlg.cpp logout-greeter/shutdowndlg.h To: davidedmundson, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
