hein added inline comments. INLINE COMMENTS
> davidedmundson wrote in taskgroupingproxymodel.cpp:1128 > Am I reading this right? > > We iterate backwards from N -> 1 because moving the desktop /might/ filter > them. > Then because we might be at 1 child, we will have ungrouped so we change the > root? > > I would expect this to not work if a user is sorting by virtual desktops. > > Would it work to generate a list of sourceIndexes from all children one loop, > then go over those indexes requesting the desktops? Can you explain how sorting comes into this? (Sorting is done a level up in TasksModel.) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13745 To: hein, mart, mvourlakos, davidedmundson Cc: anthonyfieroni, zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
