andersonbruce updated this revision to Diff 41733. andersonbruce added a comment.
- Correct overlooked comments from review D15093 <https://phabricator.kde.org/D15093> Updating D15521: Add validator for lists of IP addresses ======================================================== Added as separate review per comment from Pino on review D15093 <https://phabricator.kde.org/D15093>. This code will not compile without the updated code in review D15520 <https://phabricator.kde.org/D15520>. Also includes unit test. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15521?vs=41678&id=41733 BRANCH IPAddressListValidator REVISION DETAIL https://phabricator.kde.org/D15521 AFFECTED FILES libs/editor/CMakeLists.txt libs/editor/simpleiplistvalidator.cpp libs/editor/simpleiplistvalidator.h tests/CMakeLists.txt tests/simpleiplisttest.cpp To: andersonbruce, jgrulich, pino Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart