andersonbruce added a comment.
In D15093#323095 <https://phabricator.kde.org/D15093#323095>, @pino wrote: > Thanks Bruce for all the updates, and patience! In return, I have more notes :) > > - I'd send the changes to the existing SimpleIpV4AddressValidator in an own review request, since it affects other code than just this new wireguard plugin (maybe with unit tests) > - I'd send the addition of SimpleIpListValidator in an own review request too, since it is an independent code (possibly with unit tests) A couple of questions on opening other review requests: - Should I open a bug request on bugs.kde.org before opening the review? - Is there any special way I need to mark dependencies? That is, the simpleiplistvalidator is dependent on the updates to the simpleipv4/6 validators and WireGuard is dependent on both. - Is there a preferred unit test framework that KDE uses? And do you possibly have a pointer to a sample of other projects that use it? (Especially if they use QValidator since I tried to write some test code for my own use and I couldn't get it to not crash before it even got to main()). REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
