davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> firefox.cpp:105
> const QUrl url = result.value(QStringLiteral("url")).toUrl();
> - if (url.scheme().contains(QStringLiteral("place"))) {
> - //Don't use bookmarks with empty title, url or Firefox intern url
> + if (url.isEmpty() || url.scheme() == QStringLiteral("place")) {
> + // Don't use bookmarks with empty url or Firefox's "place:"
> scheme,
whilst we're at it
QLatin1String
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15356
To: bruns, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
