davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:309
> +        if (module && module->realModule()->inherits("KCModuleQml")) {
> +            page->setHeaderVisible(false);
> +        }

We can fix kcmmultidialog.cpp (addModule) where we have the page and the module 
object without doing weird hacks

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D14695

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to