davidedmundson added inline comments.
INLINE COMMENTS
> ModuleView.cpp:178
> // Create the scroller
> + QWidget *mainWidget = new QWidget( this );
> + QVBoxLayout *layout = new QVBoxLayout( mainWidget );
why?
> ModuleView.cpp:225
> page->setIcon( QIcon::fromTheme( moduleInfo->icon() ) );
> + //HACK: not much other ways to detect is a qml kcm
> + if (moduleProxy->realModule()->inherits("KCModuleQml")) {
we could add a property on KCModule that KCModuleQml sets
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D14581
To: mart, #plasma, #vdg
Cc: davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, sebas, apol, mart
