davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I don't see how you can be sure that the 1920_1080 resolution version of the
image exists,
It seems more that we need to patch the request *in* to bing to get a correct
Url back.
-----
Please test patches first. If you need help compiling plasma, please ask.
INLINE COMMENTS
> bingprovider.cpp:71
> }
> + auto url = urlbase + "_1920x1080.jpg";
> QUrl
> picUrl(QStringLiteral("https://www.bing.com/%1";).arg(url.toString()));
I don't see how this would compile.
urlBase is a QVariant, you can't append to it.
You need to turn it to a string (the .toString below) here.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D15026
To: carmenbianca, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
