mart added inline comments.

INLINE COMMENTS

> applet.h:70
>  public Q_SLOTS:
> -    virtual QVariant readConfig(const QString &key, const QVariant &def = 
> QString()) const;
> -    virtual void writeConfig(const QString &key, const QVariant &value);
> -    virtual QVariant readGlobalConfig(const QString &key, const QVariant 
> &def = QString()) const;
> -    virtual void writeGlobalConfig(const QString &key, const QVariant 
> &value);
> +    virtual QVariant readConfig(const QString &key, const QJSValue &def = 
> QString()) const;
> +    virtual void writeConfig(const QString &key, const QJSValue &value);

maybe it needs to return a QJSValue as well then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: mart, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to