lepagevalleeemmanuel created this revision. lepagevalleeemmanuel added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. lepagevalleeemmanuel requested review of this revision.
REVISION SUMMARY Add support for static Qt plugins. This style can now replace the default style in applications built with the static Qt SDK. It allows better encapsulation on the desktop and makes it easier to try applications on Plasma Mobile. - Remove dead code ** There was an unused class - Gnerate a QML QRC at build-time ** Since commit d0e3daafdbd <https://phabricator.kde.org/R858:d0e3daafdbdd858a5ee6e6b0b2de6a7a39ff27f1>, all QML files are now preprocessed. This renders the QRC file introduced in a few commits ago invalid since it uses the non-preprocessed files. The commit also reorder the CMake targets to make sure the files are preprecessed before the plugin is built. - Rename org.kde.qqc2desktopstyle.private to org.kde.desktop.private ** Submodules are supposed to have a consistent URI - Add an option to enable or disable plasma integration. ** The way the plugin is built is incompatible with static AppImage and probably other self contained file format. - Use the same coding style for all "private" import ** First, there was a typo in my previous commit. But the main problem was that even like that, mixing org.kde.desktop/private, org.kde.desktop.private and "private" is not very portable when switching between static and dynamic mode. TEST PLAN Not much. Works for me. It will need other users to validate it didn't regress anything for them. I would suggest not merging this as-is REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D14693 AFFECTED FILES CMakeLists.txt org.kde.desktop/Button.qml org.kde.desktop/CheckBox.qml org.kde.desktop/CheckDelegate.qml org.kde.desktop/CheckIndicator.qml org.kde.desktop/ComboBox.qml org.kde.desktop/Dial.qml org.kde.desktop/ItemDelegate.qml org.kde.desktop/Label.qml org.kde.desktop/ProgressBar.qml org.kde.desktop/RadioButton.qml org.kde.desktop/RadioDelegate.qml org.kde.desktop/ScrollBar.qml org.kde.desktop/ScrollView.qml org.kde.desktop/Slider.qml org.kde.desktop/SpinBox.qml org.kde.desktop/SwitchDelegate.qml org.kde.desktop/SwitchIndicator.qml org.kde.desktop/TabBar.qml org.kde.desktop/TabButton.qml org.kde.desktop/TextArea.qml org.kde.desktop/TextField.qml org.kde.desktop/ToolButton.qml org.kde.desktop/private/FocusRect.qml org.kde.desktop/private/qmldir org.kde.desktop/qmldir plugin/CMakeLists.txt plugin/kquickstyleitem.cpp plugin/kquickstyleitem_p.h plugin/qqc2desktopstyleplugin.cpp style.qrc.in To: lepagevalleeemmanuel, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
