davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> desktopsmodel.cpp:53
> +
> + bool connected = QDBusConnection::sessionBus().connect(
> + s_serviceName,
We can just generate the interface from the XML and use the generated class
instead of using low level classes.
> desktopsmodel.cpp:361
> +
> +const QDBusArgument &operator>>(const QDBusArgument &argument,
> KWin::DBusDesktopDataVector &deskVector)
> +{
All this is already in the kwin repo for Marco's export. We should share code
here even if it means including a C++ file from outside the kcmkwin dir.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D14542
To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen,
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
