apol added a comment.
Reviewing the patch with such menial styling changes becomes to hard, please clean up first. The spaces change is indeed correct, maybe just commit that part first, for easier review. INLINE COMMENTS > FwupdBackend.h:84 > const QUrl cacheFile(const QString &kind, const QFileInfo &resource); > - FwupdResource * createDevice(FwupdDevice *device); > - FwupdResource * createRelease(FwupdDevice *device); > - FwupdResource * createApp(FwupdDevice *device); > + FwupdResource * createDevice(FwupdDevice *dev); > + FwupdResource * createRelease(FwupdDevice *dev); Why did you change all `device` to `dev`? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 To: abhijeet2096, apol, davidedmundson Cc: plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
