dfaure added a comment.
  Ah so it's kind of a daemon, that should keep running until logout? I wasn't 
aware of that, I thought it was a KCM. Disabling as in the first patch made 
sense then ;)
  
  Either version is fine with me.

INLINE COMMENTS

> FontInst.h:161
> +    // This is needed because KJob uses an event loop locker internally,
> +    // which causes fontinst to quit after the job is done.
> +    QEventLoopLocker loopLocker;

"which would otherwise cause fontinst...."

Don't describe the past as the present, for future readers of this code ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to