kossebau added a comment.

  Thanks for the patch, I agree with you that live searching is better 
usability.
  
  So far though I had stayed away from implementing that, as I have no idea how 
the weather service providers like their servers getting more hits once in a 
while .
  
  I would prefer if we could first check the terms of usage of the currently 
used weather services before implementing this (where needed, IIRC for some 
there is a static list downloaded).

INLINE COMMENTS

> ConfigWeatherStation.qml:72
>          var config = plasmoid.nativeInterface.configValues();
> -
> +        if(config.services.length == 0) {
> +            config.services = ['wettercom']

Defaulting to the private service wetter.com goes against the idea of keeping 
the user in control of their privacy by default.

I know the current UX sucks, that popup menu is broken by design. But this is 
not a fix I can support.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D14354

To: underwit, #plasma, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to