nicolasfella added inline comments. INLINE COMMENTS
> drosca wrote in volumefeedback.cpp:36 > What if there is multiple VolumeFeedback instances? It will crash then. > You should either move canberra context to Context class (should probably be > fine) or implement the refcounting of CanberraContext similar to Context. I'd rather not move it into context so that pulseaudio-qt does not need Canberra. This way only plasma-pa would depend on Canberra REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13931 To: nicolasfella, drosca Cc: ngraham, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
